Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 14, 2025

closes #12395

Copilot AI review requested due to automatic review settings August 14, 2025 09:05
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors source mapping placement throughout the codegen module to improve accuracy and consistency. The changes adjust when and where source mappings are added during code generation to better align with the actual output positions.

  • Moves source mapping calls to more appropriate positions relative to code output
  • Removes some redundant source mappings
  • Adds source mappings for previously unmapped constructs like formal parameters and call expressions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Boshen Boshen force-pushed the 08-13-refactor_codegen_adjust_some_sourcemappings branch from 976282a to 7728d30 Compare August 14, 2025 09:10
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2025

CodSpeed Instrumentation Performance Report

Merging #13084 will improve performances by 5.13%

Comparing 08-13-refactor_codegen_adjust_some_sourcemappings (5223562) with main (fe4589b)1

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
codegen[cal.com.tsx] 35.5 ms 33.7 ms +5.13%

Footnotes

  1. No successful run was found on main (5223562) during the generation of this report, so fe4589b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Copy link
Member Author

Boshen commented Aug 14, 2025

Merge activity

@Boshen Boshen force-pushed the 08-13-refactor_codegen_adjust_some_sourcemappings branch from 7728d30 to 95a40ea Compare August 14, 2025 09:47
@graphite-app graphite-app bot force-pushed the 08-13-refactor_codegen_adjust_some_sourcemappings branch from 95a40ea to 5223562 Compare August 14, 2025 09:54
@graphite-app graphite-app bot merged commit 5223562 into main Aug 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-13-refactor_codegen_adjust_some_sourcemappings branch August 14, 2025 09:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codegen: align sourcemap generation with esbuild

2 participants