Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 14, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 14, 2025 06:44
@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor improves the consistency and readability of the remove_unused_expression module by standardizing function naming conventions and simplifying control flow patterns.

  • Renamed multiple internal methods to use consistent remove_unused_*_expr naming pattern
  • Reorganized match arms alphabetically for better maintainability
  • Simplified control flow in side effects checking methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/oxc_minifier/src/peephole/remove_unused_expression.rs Renamed helper methods and reorganized match arms alphabetically
crates/oxc_minifier/src/peephole/mod.rs Updated method calls to use new naming convention
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs Simplified if-else control flow with early returns

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

Boshen commented Aug 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 14, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-14-refactor_minifier_clean_up_remove_unused_expression_ branch from a5bbcfb to e190ee5 Compare August 14, 2025 06:49
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2025

CodSpeed Instrumentation Performance Report

Merging #13080 will not alter performance

Comparing 08-14-refactor_minifier_clean_up_remove_unused_expression_ (e190ee5) with main (2625bdf)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (e190ee5) during the generation of this report, so 2625bdf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit e190ee5 into main Aug 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-14-refactor_minifier_clean_up_remove_unused_expression_ branch August 14, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants