Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 13, 2025

Consistent naming to understand where the methods are coming from, also enforce ordering.

Copilot AI review requested due to automatic review settings August 13, 2025 16:50
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 13, 2025
@Boshen Boshen changed the title refactor(minfier): clean up method names refactor(minfier): consistent method names Aug 13, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 13, 2025
Copy link
Member Author

Boshen commented Aug 13, 2025

Merge activity

  • Aug 13, 4:50 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 14, 7:04 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Aug 14, 7:04 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Aug 14, 7:04 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 16, 3:34 AM UTC: Boshen added this pull request to the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors method names in the minifier module to improve consistency and readability. The changes enforce a consistent naming pattern where method names indicate their purpose: "substitute_" for syntax replacements, "minimize_" for size optimizations, and "replace_" for known method transformations.

  • Renamed methods to follow consistent prefixes based on their functionality
  • Reorganized method ordering and removed duplicate method declarations
  • Updated all call sites to use the new method names consistently

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
substitute_alternate_syntax.rs Renamed methods to use "substitute_" prefix and removed duplicate method declaration
replace_known_methods.rs Renamed methods to use "replace_" prefix for known method transformations
remove_unused_expression.rs Updated method call to use new naming convention
remove_dead_code.rs Renamed sequence expression method to "remove_" prefix
mod.rs Updated all method calls throughout to use new naming conventions
minimize_*.rs files Renamed methods to use "minimize_" prefix for size optimization methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 13, 2025

CodSpeed Instrumentation Performance Report

Merging #13060 will not alter performance

Comparing 08-14-refactor_minfier_clean_up_function_names (09e4063) with main (36386e4)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen force-pushed the 08-14-refactor_minfier_clean_up_function_names branch from aa4da02 to 59aa706 Compare August 14, 2025 03:11
@Boshen Boshen force-pushed the 08-14-refactor_minfier_clean_up_function_names branch from 59aa706 to 09e4063 Compare August 16, 2025 03:29
@Boshen Boshen merged commit a36c3ce into main Aug 16, 2025
26 checks passed
@Boshen Boshen deleted the 08-14-refactor_minfier_clean_up_function_names branch August 16, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants