Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 10, 2025

#12952 renamed IsGlobalReference trait to GlobalContext. But we shouldn't rewrite history - the trait was called IsGlobalReference. Revert the changes to changelogs made in that PR.

@github-actions github-actions bot added A-minifier Area - Minifier C-docs Category - Documentation. Related to user-facing or internal documentation labels Aug 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review August 10, 2025 11:19
Copilot AI review requested due to automatic review settings August 10, 2025 11:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changelog entries that incorrectly renamed historical references from IsGlobalReference to GlobalContext. The changes preserve the accuracy of historical changelog entries by restoring the original trait name that was actually used at the time those changes were made.

  • Reverts 5 changelog entries across 2 files to use the original IsGlobalReference trait name
  • Maintains historical accuracy in project documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_minifier/CHANGELOG.md Reverted 4 entries to restore original IsGlobalReference trait references
crates/oxc_ecmascript/CHANGELOG.md Reverted 1 entry to restore original IsGlobalReference trait reference

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 10, 2025
Copy link
Member

Boshen commented Aug 10, 2025

Merge activity

#12952 renamed `IsGlobalReference` trait to `GlobalContext`. But we shouldn't rewrite history - the trait *was* called `IsGlobalReference`. Revert the changes to changelogs made in that PR.
@graphite-app graphite-app bot force-pushed the 08-10-docs_ecmascript_minifier_revert_changes_to_changelogs branch from 00333d4 to 3ce27e9 Compare August 10, 2025 11:27
@graphite-app graphite-app bot merged commit 3ce27e9 into main Aug 10, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 08-10-docs_ecmascript_minifier_revert_changes_to_changelogs branch August 10, 2025 11:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 10, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
…#12962)

oxc-project#12952 renamed `IsGlobalReference` trait to `GlobalContext`. But we shouldn't rewrite history - the trait *was* called `IsGlobalReference`. Revert the changes to changelogs made in that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants