-
-
Notifications
You must be signed in to change notification settings - Fork 720
docs(ecmascript, minifier): revert changes to changelogs #12962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ecmascript, minifier): revert changes to changelogs #12962
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts changelog entries that incorrectly renamed historical references from IsGlobalReference to GlobalContext. The changes preserve the accuracy of historical changelog entries by restoring the original trait name that was actually used at the time those changes were made.
- Reverts 5 changelog entries across 2 files to use the original
IsGlobalReferencetrait name - Maintains historical accuracy in project documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_minifier/CHANGELOG.md | Reverted 4 entries to restore original IsGlobalReference trait references |
| crates/oxc_ecmascript/CHANGELOG.md | Reverted 1 entry to restore original IsGlobalReference trait reference |
Merge activity
|
#12952 renamed `IsGlobalReference` trait to `GlobalContext`. But we shouldn't rewrite history - the trait *was* called `IsGlobalReference`. Revert the changes to changelogs made in that PR.
00333d4 to
3ce27e9
Compare
…#12962) oxc-project#12952 renamed `IsGlobalReference` trait to `GlobalContext`. But we shouldn't rewrite history - the trait *was* called `IsGlobalReference`. Revert the changes to changelogs made in that PR.

#12952 renamed
IsGlobalReferencetrait toGlobalContext. But we shouldn't rewrite history - the trait was calledIsGlobalReference. Revert the changes to changelogs made in that PR.