refactor(allocator): move allocation tracking code into own module #12937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Instrumentation Performance ReportMerging #12937 will not alter performanceComparing Summary
Footnotes |
camchenry
approved these changes
Aug 9, 2025
Member
Author
Merge activity
|
Member
Author
|
Thanks for swift review @camchenry. |
…12937) Follow-on after #12555. Pure refactor. Move code related to allocation tracking into its own module, and introduce an `AllocationStats` struct. This reduces noise in `allocator.rs` and `alloc.rs`, with less repetitions of `#[cfg(all(feature = "track_allocations", not(feature = "disable_track_allocations")))]` etc. Also bulk out the doc comments explaining the unsoundness, and how we must take care to avoid allocation tracking code being compiled in production code.
graphite-app
bot
force-pushed
the
08-09-refactor_allocator_do_not_make_allocator_bump_field_public
branch
from
71ab71e to
ff1d93b
Compare
graphite-app
bot
force-pushed
the
08-09-refactor_allocator_move_allocation_tracking_code_into_own_module
branch
from
6e5f7b8 to
4f31b73
Compare
Base automatically changed from
08-09-refactor_allocator_do_not_make_allocator_bump_field_public
to
main
August 9, 2025 14:29
graphite-app
bot
deleted the
08-09-refactor_allocator_move_allocation_tracking_code_into_own_module
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…xc-project#12937) Follow-on after oxc-project#12555. Pure refactor. Move code related to allocation tracking into its own module, and introduce an `AllocationStats` struct. This reduces noise in `allocator.rs` and `alloc.rs`, with less repetitions of `#[cfg(all(feature = "track_allocations", not(feature = "disable_track_allocations")))]` etc. Also bulk out the doc comments explaining the unsoundness, and how we must take care to avoid allocation tracking code being compiled in production code.
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ocationStats` (#13043) `AllocationStats` (introduced in #12555 and #12937) previously had to contain `AtomicUsize`s because `Allocator` was `Sync`. #13033 removed the `Sync` impl for `Allocator`, so now there's no need for synchronization in `AllocationStats`, and these fields can be `Cell<usize>` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #12555. Pure refactor.
Move code related to allocation tracking into its own module, and introduce an
AllocationStatsstruct.This reduces noise in
allocator.rsandalloc.rs, with less repetitions of#[cfg(all(feature = "track_allocations", not(feature = "disable_track_allocations")))]etc.Also bulk out the doc comments explaining the unsoundness, and how we must take care to avoid allocation tracking code being compiled in production code.