fix(linter): fix no-fallthrough rule, when the default condition is not last #12927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
|
thanks for the contribution, can we add a test case for this behaviour. |
lambda47
force-pushed
the
fix/no-fallthrough-rule
branch
from
9ae4953 to
b951868
Compare
Contributor
Author
|
I add the test case for it. |
camc314
reviewed
Aug 9, 2025
CodSpeed Instrumentation Performance ReportMerging #12927 will not alter performanceComparing Summary
Footnotes |
lambda47
force-pushed
the
fix/no-fallthrough-rule
branch
from
8e2592d to
b180080
Compare
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…ot last (oxc-project#12927) In the previous implementation, if the default condition was not the last one, the order of cfg_ids was incorrect fixes oxc-project#12793 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Cameron Clark <cameron.clark@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, if the default condition was not the last one, the order of cfg_ids was incorrect
fixes #12793