Skip to content

perf(linter/new-cap): use iterator chaining instead of cloning #12879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

perf(linter/new-cap): use iterator chaining instead of cloning #12879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions crates/oxc_linter/src/rules/eslint/new_cap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ impl Rule for NewCap {
|| is_cap_allowed_expression(
short_name,
name,
&self.new_is_cap_exceptions,
self.new_is_cap_exceptions.iter(),
self.new_is_cap_exception_pattern.as_ref(),
)
|| (!self.properties && short_name != name);
Expand All @@ -498,14 +498,12 @@ impl Rule for NewCap {

let capitalization = &get_cap(short_name);

let mut caps_is_new_exceptions = self.cap_is_new_exceptions.clone();
caps_is_new_exceptions.append(&mut caps_allowed_vec());

let caps_allowed = caps_allowed_vec();
let allowed = *capitalization != GetCapResult::Upper
|| is_cap_allowed_expression(
short_name,
name,
&caps_is_new_exceptions,
self.cap_is_new_exceptions.iter().chain(caps_allowed.iter()),
self.cap_is_new_exception_pattern.as_ref(),
)
|| (!self.properties && short_name != name);
Expand Down Expand Up @@ -628,14 +626,16 @@ fn extract_name_from_expression(expression: &Expression) -> Option<CompactStr> {
}
}

fn is_cap_allowed_expression(
fn is_cap_allowed_expression<'a>(
short_name: &CompactStr,
name: &CompactStr,
exceptions: &[CompactStr],
exceptions: impl Iterator<Item = &'a CompactStr>,
patterns: Option<&Regex>,
) -> bool {
if exceptions.contains(name) || exceptions.contains(short_name) {
return true;
for exception in exceptions {
if exception == name || exception == short_name {
return true;
}
}

if name == "Date.UTC" {
Expand Down
Loading