Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Aug 7, 2025

Related to #12825

@github-actions github-actions bot added the A-linter Area - Linter label Aug 7, 2025
Copy link
Member Author

shulaoda commented Aug 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 7, 2025
@shulaoda shulaoda changed the title refactor(linter/no-unassigned-import): use fast-glob instead of globset refactor(linter/no-unassigned-import): use fast-glob instead of globset Aug 7, 2025
@shulaoda shulaoda marked this pull request as ready for review August 7, 2025 08:05
@shulaoda shulaoda requested a review from camc314 as a code owner August 7, 2025 08:05
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed Instrumentation Performance Report

Merging #12867 will not alter performance

Comparing 08-07-refactor_linter_no-unassigned-import_use_fast-glob_instead_of_globset (78c311c) with main (fcdb91d)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (78c311c) during the generation of this report, so fcdb91d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@shulaoda
Copy link
Member Author

shulaoda commented Aug 7, 2025

The fast-glob matching behavior alignes with import/no-unassigned-import. The original globset implementation had some issues in this regard. #12870 (comment)

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 7, 2025
Copy link
Contributor

camc314 commented Aug 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-07-refactor_linter_no-unassigned-import_use_fast-glob_instead_of_globset branch from 07a9059 to 78c311c Compare August 7, 2025 15:25
@graphite-app graphite-app bot merged commit 78c311c into main Aug 7, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 08-07-refactor_linter_no-unassigned-import_use_fast-glob_instead_of_globset branch August 7, 2025 15:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 7, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants