Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Aug 7, 2025

Related to #12825

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 7, 2025
Copy link
Member Author

shulaoda commented Aug 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda marked this pull request as ready for review August 7, 2025 05:54
@shulaoda shulaoda requested review from Sysix and camc314 as code owners August 7, 2025 05:54
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 7, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Aug 7, 2025
@graphite-app graphite-app bot force-pushed the 08-07-refactor_oxc_language_server_remove_unnecessary_globset branch from 3ff78e6 to 67705a7 Compare August 7, 2025 05:59
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed Instrumentation Performance Report

Merging #12861 will not alter performance

Comparing 08-07-refactor_oxc_language_server_remove_unnecessary_globset (9b9249d) with main (bc1d716)

Summary

✅ 34 untouched benchmarks

@shulaoda shulaoda force-pushed the 08-07-refactor_oxc_language_server_remove_unnecessary_globset branch from 67705a7 to 9b9249d Compare August 7, 2025 06:04
@shulaoda shulaoda changed the title refactor(oxc_language_server): remove unnecessary globset refactor(oxc_language_server): remove unnecessary globset Aug 7, 2025
@graphite-app graphite-app bot merged commit 9b9249d into main Aug 7, 2025
34 checks passed
@graphite-app graphite-app bot deleted the 08-07-refactor_oxc_language_server_remove_unnecessary_globset branch August 7, 2025 06:10
@shulaoda
Copy link
Member Author

shulaoda commented Aug 7, 2025

@camc314 Sorry, I forgot that ticking "Merge When Ready" in OXC’s Graphite makes the PR merge automatically.

@camc314
Copy link
Contributor

camc314 commented Aug 7, 2025

No worries, this change looks fine, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants