feat(isolated-declarations)!: Rewrite declare module X to declare namespace X
#12845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-isolated-declarations
CodSpeed Instrumentation Performance ReportMerging #12845 will not alter performanceComparing Summary
|
Dunqing
requested changes
Aug 6, 2025
Member
Author
|
@Dunqing Thanks for the review~! Updated. 👍🏻 |
Dunqing
approved these changes
Aug 7, 2025
Member
Merge activity
|
graphite-app
bot
force-pushed
the
dts-module-to-ns
branch
from
8278190 to
306b023
Compare
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…namespace X` (oxc-project#12845) May fix oxc-project#12844 At first glance, it looked like a simple change, so I created a PR. But sorry, I think I'm not familiar with the context, so please feel free to close if not appropriate. 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #12844
At first glance, it looked like a simple change, so I created a PR.
But sorry, I think I'm not familiar with the context, so please feel free to close if not appropriate. 😓