Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 6, 2025

No description provided.

Copy link
Member Author

Dunqing commented Aug 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title correct comments printing between function name with params and between function params with body feat(formatter):correct comments printing between function name with params and between function params with body Aug 6, 2025
@Dunqing Dunqing changed the title feat(formatter):correct comments printing between function name with params and between function params with body feat(formatter): correct comments printing between function name with params and between function params with body Aug 6, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Aug 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 6, 2025

CodSpeed Instrumentation Performance Report

Merging #12836 will not alter performance

Comparing correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body (05f7f88) with main (d9268fa)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing marked this pull request as ready for review August 7, 2025 07:17
@Dunqing Dunqing requested a review from overlookmotel as a code owner August 7, 2025 07:17
@Dunqing Dunqing removed the request for review from overlookmotel August 7, 2025 07:19
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 7, 2025
@Dunqing Dunqing force-pushed the correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body branch from 4a8e6fe to 1d62ba9 Compare August 7, 2025 14:12
@Dunqing Dunqing force-pushed the 08-05-feat_formatter_complete_printing_importdeclaration branch from 52c4d0c to f8edba4 Compare August 7, 2025 14:12
@graphite-app graphite-app bot force-pushed the 08-05-feat_formatter_complete_printing_importdeclaration branch from f8edba4 to a99aef3 Compare August 7, 2025 14:26
@graphite-app graphite-app bot force-pushed the correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body branch from 1d62ba9 to 791ba72 Compare August 7, 2025 14:26
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 7, 2025

Merge activity

  • Aug 7, 2:35 PM UTC: Boshen added this pull request to the Graphite merge queue.
  • Aug 7, 2:44 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Aug 7, 2:50 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 7, 2:50 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Aug 7, 2:50 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Aug 7, 2:57 PM UTC: graphite-app added this pull request to the Graphite merge queue.
  • Aug 7, 3:14 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 08-05-feat_formatter_complete_printing_importdeclaration to graphite-base/12836 August 7, 2025 14:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 7, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/12836 to main August 7, 2025 14:43
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 7, 2025
@Boshen Boshen force-pushed the correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body branch from 791ba72 to a2979e4 Compare August 7, 2025 14:50
graphite-app bot pushed a commit that referenced this pull request Aug 7, 2025
… params and between function params with body (#12836)
@graphite-app graphite-app bot force-pushed the correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body branch from a2979e4 to 576ab9e Compare August 7, 2025 14:57
… params and between function params with body (#12836)
@graphite-app graphite-app bot force-pushed the correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body branch from 576ab9e to 05f7f88 Compare August 7, 2025 15:04
@graphite-app graphite-app bot merged commit 05f7f88 into main Aug 7, 2025
30 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 7, 2025
@graphite-app graphite-app bot deleted the correct_comments_printing_between_function_name_with_params_and_between_function_params_with_body branch August 7, 2025 15:14
taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants