Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 5, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 5, 2025
Copy link
Contributor Author

camc314 commented Aug 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314
Copy link
Contributor Author

camc314 commented Aug 5, 2025

lets see if this breaks anyone:

After fixing #12833, this rule has not had any false positives, and has raised correctness issues in user code.

Making this rule have the "correctness" category feels like the right thing to do.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed Instrumentation Performance Report

Merging #12832 will not alter performance

Comparing c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ (c2d3464) with main (2c1dab6)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (c2d3464) during the generation of this report, so 2c1dab6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 changed the base branch from main to graphite-base/12832 August 5, 2025 12:43
@camc314 camc314 force-pushed the c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ branch from 3cf0d58 to bf54c08 Compare August 5, 2025 12:43
@camc314 camc314 changed the base branch from graphite-base/12832 to c/08-05-fix_linter_no-unassigned-vars_false_positive_with_variables_in_for_loop August 5, 2025 12:43
@graphite-app graphite-app bot changed the base branch from c/08-05-fix_linter_no-unassigned-vars_false_positive_with_variables_in_for_loop to graphite-base/12832 August 5, 2025 12:48
@camc314 camc314 marked this pull request as ready for review August 5, 2025 12:50
@camc314 camc314 force-pushed the graphite-base/12832 branch from cf31e85 to 2c1dab6 Compare August 5, 2025 12:51
@camc314 camc314 force-pushed the c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ branch from bf54c08 to a4e2cc1 Compare August 5, 2025 12:51
@github-actions github-actions bot added the A-cli Area - CLI label Aug 5, 2025
@camc314 camc314 added 0-merge Merge with Graphite Merge Queue and removed A-cli Area - CLI labels Aug 5, 2025
Copy link
Contributor Author

camc314 commented Aug 5, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/12832 to main August 5, 2025 12:52
@graphite-app graphite-app bot force-pushed the c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ branch from a4e2cc1 to f57335f Compare August 5, 2025 12:52
@github-actions github-actions bot added the A-cli Area - CLI label Aug 5, 2025
@camc314 camc314 force-pushed the c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ branch from f57335f to e6aea1b Compare August 5, 2025 13:10
@camc314 camc314 requested a review from Sysix as a code owner August 5, 2025 13:10
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Aug 5, 2025
@graphite-app graphite-app bot force-pushed the c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ branch from e6aea1b to c2d3464 Compare August 5, 2025 13:17
@graphite-app graphite-app bot merged commit c2d3464 into main Aug 5, 2025
29 checks passed
@graphite-app graphite-app bot deleted the c/08-05-chore_linter_no-unassigned-vars_move_to_category_to_correctness_ branch August 5, 2025 13:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants