refactor(parser): add StatementContext::TopLevelStatementList
#12806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
CodSpeed Instrumentation Performance ReportMerging #12806 will not alter performanceComparing Summary
Footnotes |
This was referenced Aug 4, 2025
Contributor
Merge activity
|
Pure refactor. Allow parser functions to determine whether in top level context or not, by adding `TopLevelStatementList` variant to `StatementContext`. Also, re-order the variants to make `StatementContext::is_single_statement` as cheap as possible - with `StatementList` and `TopLevelStatementList` as first 2 variants, `is_single_statement` boils down to `self as u8 < 2`. This new variant is used in the next PR in this stack.
graphite-app
bot
force-pushed
the
08-04-refactor_parser_add_statementcontext_toplevelstatementlist_
branch
from
020e6f5 to
febb4fa
Compare
graphite-app
bot
deleted the
08-04-refactor_parser_add_statementcontext_toplevelstatementlist_
branch
This was referenced Aug 6, 2025
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…project#12806) Pure refactor. Allow parser functions to determine whether in top level context or not, by adding `TopLevelStatementList` variant to `StatementContext`. Also, re-order the variants to make `StatementContext::is_single_statement` as cheap as possible - with `StatementList` and `TopLevelStatementList` as first 2 variants, `is_single_statement` boils down to `self as u8 < 2`. This new variant is used in the next PR in this stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Allow parser functions to determine whether in top level context or not, by adding
TopLevelStatementListvariant toStatementContext.Also, re-order the variants to make
StatementContext::is_single_statementas cheap as possible - withStatementListandTopLevelStatementListas first 2 variants,is_single_statementboils down toself as u8 < 2.This new variant is used in the next PR in this stack.