Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 3, 2025

This is on a really cold path, so no expected performance improvement.

@github-actions github-actions bot added A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance labels Aug 3, 2025
Copy link
Member Author

Boshen commented Aug 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen force-pushed the 08-03-perf_parser_remove_a_bound_check_in_match_keyword_ branch from 300fbc6 to c64287f Compare August 3, 2025 10:25
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 3, 2025

CodSpeed Instrumentation Performance Report

Merging #12778 will not alter performance

Comparing 08-03-perf_parser_remove_a_bound_check_in_match_keyword_ (00bdfc0) with main (09ae2a9)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (00bdfc0) during the generation of this report, so 09ae2a9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 3, 2025
Copy link
Member Author

Boshen commented Aug 3, 2025

Merge activity

@Boshen Boshen force-pushed the 08-03-perf_parser_remove_a_bound_check_in_match_keyword_ branch from 30a39e4 to c64287f Compare August 3, 2025 11:30
This is on a really cold path, so no expected performance improvement.
@graphite-app graphite-app bot force-pushed the 08-03-perf_parser_remove_a_bound_check_in_match_keyword_ branch from c64287f to 00bdfc0 Compare August 3, 2025 11:37
@graphite-app graphite-app bot merged commit 00bdfc0 into main Aug 3, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-03-perf_parser_remove_a_bound_check_in_match_keyword_ branch August 3, 2025 11:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 3, 2025
This was referenced Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants