Skip to content

fix(linter/explicit-mod-boundary-types): false positive with jsx elements #12678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix(linter/explicit-mod-boundary-types): false positive with jsx elements #12678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/oxc_linter/src/rules/typescript/explicit_module_boundary_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,10 @@ impl<'a> Visit<'a> for ExplicitTypesChecker<'a, '_> {
// ignore
}

fn visit_jsx_element(&mut self, _it: &JSXElement<'a>) {
// ignore
}

fn visit_class(&mut self, class: &Class<'a>) {
let had_id = self.with_target_binding(class.id.as_ref());
walk::walk_class_body(self, class.body.as_ref());
Expand Down Expand Up @@ -1480,6 +1484,10 @@ mod test {
"const ex = () => (args: { fn: (arg: string) => void }) => args; export const Test = ex()({ fn: () => {} });",
None,
),
(
"function ErrorTrackingRules(): JSX.Element { return (<BindLogic><DndContext onDragEnd={({ active, over }) => { /**/ }}></DndContext></BindLogic>); }; export default ErrorTrackingRules;",
None,
),
];

let fail = vec![
Expand Down
Loading