Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/oxc_linter/src/rules/typescript/array_type.rs
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ fn is_simple_type(ts_type: &TSType) -> bool {
if node.type_arguments.is_some() {
return false;
}
if let TSTypeName::IdentifierReference(_) = &node.type_name {
if node.type_name.is_identifier() || node.type_name.is_qualified_name() {
return true;
}
return false;
Expand Down Expand Up @@ -970,9 +970,17 @@ export const test = testFn<{name: string}>({name: 'test'});",
const instance = new MyClass<number>(42);",
Some(serde_json::json!([{"default":"generic"}])),
),
// https://github.com/oxc-project/oxc/issues/12605
("let a: factories.User[] = [];", Some(serde_json::json!([{"default":"array-simple"}]))),
("let a: factories.TT.User[] = [];", Some(serde_json::json!([{"default":"array-simple"}]))),
(
"let z: readonly factories.User[] = [];",
Some(serde_json::json!([{"readonly":"array-simple"}])),
),
];

let fail = vec![
("let a: factories.User[] = [];", Some(serde_json::json!([{"default":"generic"}]))),
("let a: Array<number> = [];", Some(serde_json::json!([{"default":"array"}]))),
("let a: Array<string | number> = [];", Some(serde_json::json!([{"default":"array"}]))),
("let a: ReadonlyArray<number> = [];", Some(serde_json::json!([{"default":"array"}]))),
Expand Down
7 changes: 7 additions & 0 deletions crates/oxc_linter/src/snapshots/typescript_array_type.snap
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
---
source: crates/oxc_linter/src/tester.rs
---
⚠ typescript-eslint(array-type): Array type using 'factories.User[]' is forbidden. Use 'Array<factories.User>' instead.
╭─[array_type.ts:1:8]
1 │ let a: factories.User[] = [];
· ────────────────
╰────
help: Replace `factories.User[]` with `Array<factories.User>`.

⚠ typescript-eslint(array-type): Array type using 'Array<number>' is forbidden. Use 'number[]' instead.
╭─[array_type.ts:1:8]
1 │ let a: Array<number> = [];
Expand Down
Loading