Skip to content

refactor(minifier): do not remove unused assignment expression yet #12367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

refactor(minifier): do not remove unused assignment expression yet #12367

merged 1 commit into from
Jul 17, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 17, 2025

it's broken for

export let foo;
foo = 1;

closes #12340

@Boshen Graphite App
Copy link
Member Author

Boshen commented Jul 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-minifier Area - Minifier label Jul 17, 2025
@Boshen Boshen mentioned this pull request Jul 17, 2025
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 17, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12367 will not alter performance

Comparing 07-17-refactor_minifier_do_not_remove_unused_assignment_expression_yet (cc3bea4) with main (14f0159)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot force-pushed the more-remove-assign branch from 1ae49d4 to ed696b5 Compare July 17, 2025 14:05
graphite-app bot pushed a commit that referenced this pull request Jul 17, 2025
@Boshen
refactor(minifier): do not remove unused assignment expression yet (#…
f8a8c0c 
…12367)

it's broken for

```js
export let foo;
foo = 1;
```

closes #12340
@graphite-app graphite-app bot force-pushed the 07-17-refactor_minifier_do_not_remove_unused_assignment_expression_yet branch from 8148c86 to f8a8c0c Compare July 17, 2025 14:05
Base automatically changed from more-remove-assign to main July 17, 2025 14:12
@Boshen
refactor(minifier): do not remove unused assignment expression yet (#…
cc3bea4 
…12367)

it's broken for

```js
export let foo;
foo = 1;
```

closes #12340
@graphite-app graphite-app bot force-pushed the 07-17-refactor_minifier_do_not_remove_unused_assignment_expression_yet branch from f8a8c0c to cc3bea4 Compare July 17, 2025 14:13
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 17, 2025

Merge activity

@graphite-app graphite-app bot merged commit cc3bea4 into main Jul 17, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-17-refactor_minifier_do_not_remove_unused_assignment_expression_yet branch July 17, 2025 14:21
@oxc-bot oxc-bot mentioned this pull request Jul 17, 2025
Merged
@sapphi-red sapphi-red mentioned this pull request Jul 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minifier: removes assignment to exported variables

2 participants

@Boshen