fix(parser): allocate all strings in arena #11738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11738 will improve performances by 12.72%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
Fix #11723. Fix 2 cases where parser was using static strings for AST nodes. This is fine on Rust side, but it breaks raw transfer, because raw transfer requires all data (including strings) to be in the arena. All it knows is what's in the arena, and a `&'static str` is stored outside that, so it can't read the string data. Unfortunately, we have no way to statically prevent putting an `Atom` created from a `&'static str` in AST, because type system allows a `'static` lifetime to be "squeezed" down to `'a`. So we have to play "whack-a-mole" with any such bugs at present (unfortunately conformance tests don't cover the cases in #11723).
graphite-app
bot
force-pushed
the
06-16-feat_parser_introduce_parserimpl_token_source_method
branch
from
4bc8335 to
e05d9bb
Compare
graphite-app
bot
force-pushed
the
06-16-fix_parser_allocate_all_strings_in_arena
branch
from
47d7ed8 to
854b0f1
Compare
Base automatically changed from
06-16-feat_parser_introduce_parserimpl_token_source_method
to
main
June 16, 2025 11:20
graphite-app
bot
deleted the
06-16-fix_parser_allocate_all_strings_in_arena
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11723.
Fix 2 cases where parser was using static strings for AST nodes.
This is fine on Rust side, but it breaks raw transfer, because raw transfer requires all data (including strings) to be in the arena. All it knows is what's in the arena, and a
&'static stris stored outside that, so it can't read the string data.Unfortunately, we have no way to statically prevent putting an
Atomcreated from a&'static strin AST, because type system allows a'staticlifetime to be "squeezed" down to'a. So we have to play "whack-a-mole" with any such bugs at present (unfortunately conformance tests don't cover the cases in #11723).