Skip to content

Conversation

@ulrichstark
Copy link
Contributor

Handle re-exporting of type correctly in import/no-cycle lint rule.
Added one passing test (ignoreTypes = default/true) and one failing test (ignoreTypes = false).
Closes #10547

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Apr 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10606 will not alter performance

Comparing ulrichstark:handle-re-exporting-of-type-in-no-cycle-lint-rule (dc54d92) with main (0825834)

Summary

✅ 36 untouched benchmarks

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

Merge activity

  • Apr 24, 7:23 PM EDT: @ulrichstark we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
@camchenry camchenry merged commit 39adefe into oxc-project:main Apr 24, 2025
25 checks passed
@ulrichstark ulrichstark deleted the handle-re-exporting-of-type-in-no-cycle-lint-rule branch April 25, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: import/no-cycle false neg for export type

2 participants