semantics: references created by direct eval in non-strict mode is not respected

[sapphi-red]

Currently semantic does not track the existence of direct eval.
is_global_reference may return true even if that reference refers to a variable declared by direct eval (the declaration is only leaked outside in non-strict mode).

oxc/crates/oxc_semantic/src/symbol.rs

Lines 342 to 346 in e4d66e4

	fn is_global_reference(&self, symbols: &SymbolTable) -> bool {
	self.reference_id
	.get()
	.is_some_and(|reference_id| reference_id.is_global_reference(symbols))
	}

This leads to minification errors for codes like:

function foo() {
  eval('var Object = class { constructor() { console.log("Constructor") } }')
  console.log(new Object())
}

foo()

playground

I'd say just never use direct eval 😅 But leaving a note for reference. (This is not something I met with real world code)

[Boshen]

All logic related to eval has not been implemented yet. We need to either implement them or warn about it. Note: esbuild bails minification and mangling for all parent scopes containing eval.

[Boshen]

Direct eval disables the mangler.

oxc/crates/oxc_mangler/src/lib.rs

Lines 195 to 198 in 0b08159

	// TODO: implement opt-out of direct-eval in a branch of scopes.
	if scope_tree.root_flags().contains_direct_eval() {
	return symbol_table;
	}

[sapphi-red]

It's not only the mangler. We need to disable all the compression that uses is_global_reference or relies on any information related to variables / functions. The reproduction in the OP is still broken.