Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustdoc comments to all public APIs #5870

Closed
2 of 9 tasks
DonIsaac opened this issue Sep 19, 2024 · 9 comments
Closed
2 of 9 tasks

Add rustdoc comments to all public APIs #5870

DonIsaac opened this issue Sep 19, 2024 · 9 comments
Labels
C-docs Category - Documentation. Related to user-facing or internal documentation E-Help Wanted Experience level - For the experienced collaborators

Comments

@DonIsaac
Copy link
Collaborator

DonIsaac commented Sep 19, 2024

Good documentation is a critical part of promoting adoption from other projects. If users cannot understand how to use our tools, odds are they wont. We should document as much of our public API as possible. At the very least, all mostly-stable APIs should have examples and descriptions on how to use them.

We have a lot of great examples, but many options and return structures are missing descriptions. Plenty of business logic is also missing descriptions.

Crates

These are, in my opinion, the crates that are most important to document right now

Basically, if it's used anywhere from reading a file -> parsing -> transforming -> printing, then it is a high-priority candidate.

@DonIsaac DonIsaac added good first issue Experience Level - Good for newcomers C-docs Category - Documentation. Related to user-facing or internal documentation labels Sep 19, 2024
Boshen pushed a commit that referenced this issue Sep 19, 2024
@overlookmotel
Copy link
Collaborator

overlookmotel commented Sep 19, 2024

Just to add, documentation on internal APIs is also helpful - not just for new contributors, but also for the core team. I often find myself a bit lost in areas of codebase I've not been in for a while. Obviously, public API is higher priority, though.

@DonIsaac
Copy link
Collaborator Author

I'm not familiar enough with the transformer to tackle this. Is someone else willing to handle it?

@overlookmotel
Copy link
Collaborator

I am currently working through the transformer fixing bugs and refactoring. I'll do my best to also add comments as I go. FYI we've adopted a "style guide" for writing transforms which includes requirement to comment well.

@DonIsaac
Copy link
Collaborator Author

I'm not familiar enough with the transformer to tackle this. Is someone else willing to handle it?

I'm also not super familiar with codegen or ID, would love support on these

@DonIsaac DonIsaac added E-Help Wanted Experience level - For the experienced collaborators and removed good first issue Experience Level - Good for newcomers labels Sep 26, 2024
DonIsaac pushed a commit that referenced this issue Oct 4, 2024
- towards #5870

Adds some very basic docs for methods and properties related to `LintContext` and `ContextHost`.
camchenry added a commit that referenced this issue Oct 4, 2024
- towards #5870

Adds some very basic docs for methods and properties related to `LintContext` and `ContextHost`.
camchenry added a commit that referenced this issue Oct 4, 2024
- towards #5870

Adds some very basic docs for methods and properties related to `LintContext` and `ContextHost`.
@Boshen
Copy link
Member

Boshen commented Oct 10, 2024

It seems like we can add missing_docs = "warn" one by one to these crates.

@Boshen
Copy link
Member

Boshen commented Oct 14, 2024

Close as stale for house keeping. Nobody likes writing documentations so I don't think we'll get any help 😅

@Boshen Boshen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@overlookmotel
Copy link
Collaborator

Moving to backlog, as I think this is something that we should tackle at some point - I believe it is important, for the reasons that Don gives at the top.

@overlookmotel overlookmotel reopened this Oct 14, 2024
@overlookmotel
Copy link
Collaborator

Transferring to backlog repo did not work. Github seems to have some kind of race condition. Going to leave this for a few hours for it to settle down and then try again.

@overlookmotel
Copy link
Collaborator

Transferred to oxc-project/backlog#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category - Documentation. Related to user-facing or internal documentation E-Help Wanted Experience level - For the experienced collaborators
Projects
None yet
Development

No branches or pull requests

3 participants