linter: oxc plugin report some errors which was turned off in oxlintrc

[congjiujiu]

What version of Oxlint are you using?

1.4.0

What command did you run?

No response

What does your .oxlintrc.json config file look like?

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "plugins": [
    "typescript",
    "unicorn",
    "react"
  ],
  "ignorePatterns": [
    "dist",
    "node_modules",
    "src/**/*.js",
    "packages/api/src/**/api.ts",
    "public"
  ],
  "categories": {
    "correctness": "error",
    "restriction": "error",
    "style": "error"
  },
  "rules": {
    "eqeqeq": [
      2,
      "always",
      {
        "null": "ignore"
      }
    ],
    "no-console": [
      2,
      {
        "allow": [
          "warn",
          "error",
          "info",
          "assert",
          "debug",
          "group",
          "groupEnd"
        ]
      }
    ],
    "no-var": 2,
    "no-const-assign": 2,
    "no-extra-boolean-cast": 1,
    "no-constant-binary-expression": 1,
    "no-unused-vars": [
      "error",
      {
        "varsIgnorePattern": "^_",
        "argsIgnorePattern": "^_",
        "caughtErrorsIgnorePattern": "^_"
      }
    ],
    "arrow-body-style": 0,
    "curly": 1,
    "func-style": 0,
    "func-names": 0,
    "id-length": 0,
    "init-declarations": 0,
    "max-params": 0,
    "no-alert": 0,
    "no-continue": 0,
    "no-danger": 1,
    "no-magic-numbers": 0,
    "no-nested-ternary": 0,
    "no-plusplus": 0,
    "no-ternary": 0,
    "no-undefined": 0,
    "no-void": 0,
    "prefer-global-this": 0,
    "prefer-exponentiation-operator": 0,
    "sort-imports": 0,
    "sort-keys": 0,
    "yoda": 0
  },
  "overrides": [
    {
      "files": [
        "**/*.{ts,tsx,mts}"
      ],
      "plugins": [
        "typescript"
      ],
      "rules": {
        "typescript/array-type": 0,
        "typescript/consistent-indexed-object-style": 0,
        "typescript/consistent-type-imports": 0,
        "typescript/consistent-type-definitions": 1,
        "typescript/explicit-function-return-type": 0,
        "typescript/explicit-module-boundary-types": 0,
        "typescript/no-explicit-any": 1,
        "typescript/no-non-null-assertion": 0
      }
    },
    {
      "files": [
        "**/*.{ts,tsx}"
      ],
      "plugins": [
        "react"
      ],
      "rules": {
        "react/display-name": 0,
        "react/exhaustive-deps": 2,
        "react/jsx-no-multiline-js": 0,
        "react/jsx-equals-spacing": 0,
        "react/jsx-no-target-blank": 0,
        "react/jsx-key": 2,
        "react/jsx-boolean-value": 0,
        "react/jsx-filename-extension": 0,
        "react/no-find-dom-node": 0,
        "react/no-string-refs": 2,
        "react/no-unescaped-entities": 0,
        "react/prop-types": 0,
        "react/react-in-jsx-scope": 0,
        "react/rules-of-hooks": 2,
        "react/self-closing-comp": 2
      }
    },
    {
      "files": [
        "**/*.{ts,tsx,mts}"
      ],
      "plugins": [
        "unicorn"
      ],
      "rules": {
        "unicorn/filename-case": [
          "error",
          {
            "case": "kebabCase",
            "multipleFileExtensions": true
          }
        ],
        "unicorn/catch-error-name": 0,
        "unicorn/no-null": 0,
        "unicorn/no-abusive-eslint-disable": 0,
        "unicorn/no-array-for-each": 1,
        "unicorn/no-array-reduce": 0,
        "unicorn/no-nested-ternary": 0,
        "unicorn/numeric-separators-style": 0,
        "unicorn/prefer-optional-catch-binding": 0,
        "unicorn/prefer-includes": 1,
        "unicorn/prefer-spread": 1,
        "unicorn/switch-case-braces": 0
      }
    }
  ]
}

What happened?

it was everything good last day, and today i reload my vscode, some rule errors was reported by oxlint, but these rules was turned off in oxlintrc so long before.

for example:

and the rule react/jsx-filename-extension was set to 0 in oxlintrc.

I think its the bug of this release:

the bug happens just after the release time

[camc314]

Thanks for reporting this, and using oxlint.

This issue isn't limited to the language server, but both the cli and the language server.

This bug has appeared as a result of #12788, the cause of this bug was when rules were enabled by categories, they would have the incorrect default implementation.

To explain why this is happening I've simplified the config file:

{
  "plugins": [
    "typescript",
    "unicorn",
    "react"
  ],
  "categories": {
    "correctness": "error",
    "restriction": "error",
    "style": "error"
  },
  "rules": { },
  "overrides": [
    {
      "files": ["**/*.{ts,tsx,mts}"],
      "plugins": ["typescript"],
      "rules": {}
    },
    {
      "files": ["**/*.{ts,tsx}"],
      "plugins": ["react"],
      "rules": { "react/jsx-filename-extension": "off" }
    },
    {
      "files": ["**/*.{ts,tsx,mts}"],
      "plugins": ["unicorn"],
      "rules": {}
    }
  ]
}

When resolving the correct rules for a .tsx file, we apply the root config, then apply the matching overrides.
This means the config looks like:

• after root is applied: react/jsx-filename-extension: error
• after the first override is applied: react/jsx-filename-extension: error
• after the second override is applied: react/jsx-filename-extension: off
• after the third override is applied: react/jsx-filename-extension: error

This is because the plugins in the 3rd override have changed (to include unicorn), we combine this list of plugins with the plugins list from the root, and apply the categories from the root which causes react/jsx-filename-extension to now have the error severity.

I think the root cause of this is that we merge plugins from the root with plugins inside the override array, however I don't think we can change that without a breaking change

[camc314]

Ok, i've come up with a solution to this, will release a patch this afternoon hopefully