unicorn/prefer-string-starts-ends-with transforms code to .endsWith("\") if the char is `$`.

[jdalton]

unicorn/prefer-string-starts-ends-with transforms code to .endsWith("") if the char is $.

in at least v0.16.6

[jdalton]

Wow, thank you!

[jdalton]

After the fix seeing other transforms that are problematic

✖ unexpected unicode escape

17241 │   typeof process !== 'undefined' && (process.env && process.env.IGNORE_TEST_WIN32 || process.platform === 'win32')) {
17242 │     /* eslint no-control-regex: "off" */

17243 │ const makePosix = str => str.startsWith("\?") || /["<>|\u0000-\u001F]+/u.test(str) ? str : str.replace(/\/g, '/');
│ ^^^^^
17244 │ checkPath.convert = makePosix;
17245 │

ℹ this escape is unexpected, as it does not designate the start of an identifier

[camc314]

hmm i was worried about this, and i thought i accounted for this case. but i guess not. thanks for reporting, will look

[camc314]

do you have a full repro?

i tried

https://playground.oxc.rs/#eNo9j7tqxEAMRf9FpEjAZJNAGjdpwrYJSbuNPJaXgbFkJM0+WPzvO7PGrvRAOvfeGwRoYXc4fD3tXp3MnweRF2hAoL2BZq7Frux4gdY1UwMpsq+9BZloG65jJ2mdXJFtEB2hHTAZzQ1MqEZaiZiSnP/Is/JPdos97TMHj1L0lvdJqdye6BeV2JZtQVTxB6L0m8LCdNQjFWdA9vH2/lkyRJOETv03hYSKFV9Iq5sgPR3pEZAYu0T/kjXQiNOmNkaOQ1z1grCrpH2xXp9OpJ1YSb8A5/kOLCR2Sg==

which appears to fix it correctly.

on mobile right now but will double check later

[camc314]

or was the input:

const makePosix = str => /^\\\\\?\\/.test(str)

I see for the above, we need to escape the last slash

[camc314]

should be fixed in the next release 🤞