feat(napi): add tracing-subscriber feature; turned on by default
#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new feature to support the tracing-subscriber integration in the napi module and turns it on by default.
- Added conditional initialization of tracing based on the "tracing-subscriber" feature in napi/src/lib.rs.
- Updated Cargo.toml to make tracing-subscriber an optional dependency that is enabled by default.
- Removed outdated Rspack instructions from README.md.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| napi/src/lib.rs | Wrapped tracing initialization with a feature flag condition. |
| napi/Cargo.toml | Set tracing-subscriber as an optional dependency and included it by default. |
| README.md | Removed obsolete Rspack instructions. |
Boshen
deleted the
06-05-feat_napi_add_tracing-subscriber_feature_turned_on_by_default
branch
Merged
Boshen
pushed a commit
that referenced
this pull request
Jun 5, 2025
## 🤖 New release * `oxc_resolver`: 11.1.0 -> 11.2.0 (✓ API compatible changes) * `oxc_resolver_napi`: 11.1.0 -> 11.2.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `oxc_resolver` <blockquote> ## [11.2.0](oxc_resolver-v11.1.0...oxc_resolver-v11.2.0) - 2025-06-05 ### <!-- 0 -->Features - *(napi)* add `tracing-subscriber` feature; turned on by default ([#546](#546)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #545