fix: preserve newlines in block comments to match JavaScript behavior #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Rust implementation to preserve newlines (
\nand\r) within block comments, matching the behavior of the JavaScriptsindresorhus/strip-json-commentslibrary.Changes
Block Comments
consume_block_comments()to iterate through characters and only replace non-newline characters with spacesmaybe_comment_end()to preserve\nand\rcharactersLine Comments
consume_line_comments()to preserve\rwhen it appears immediately before\n(Windows line endings\r\n)Test Results
All 48 tests pass, including the ported tests from sindresorhus that now correctly expect newlines to be preserved.
Before:
After:
Related
Builds on #118 which ported the test suite from the JavaScript implementation.
🤖 Generated with Claude Code