RTX Delivery (PI-5) Enhancements to HFsubset to support Replace and Route #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create get_shortestpath.R Created shortest path * Working code for shortest path * Update get_shortestpath.R * reformatted get_shortest_path to output more layers and fit with existing code * adding compliation changes --------- Co-authored-by: CalebNovinger <caleb.d.novinger@rtx.com>
|
I would support integrating this but do not want to drag tidygraph around. If we can do this with hydroloom/igraph it would be excellent! Do you want to look into that or should I? |
|
I can take at stab at switching the dependency on our end and push an update. I noticed the test coverage failed... makes me think 1-2 tests for the new function would be good to ensure this function has coverage with any code changes in the future. It will be my first time using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replace and Route runs on segments from the NHD RouteLink for routing NWPS forecasts downstream. These segments are generated using a domain generator built into the NOAA-OWP/Hydrovis Domain generator. Given NOAA's switch to the v2.2 Hydrofabric, we have created a new function to generate a subset of the Hydrofabric between two NHD COMIDs to best address this need
See here for production segment data
Capability:
Create an instance of the subsetting tool, hfsubsetR, with a functional endpoint and the functional endpoint and the functionality needed to complete associated deliverables.
What was added:
R/get_shortest_path.Rto create segments between two NHD comidsExample: Here is a shortest path (green) and the end of a subset (red/orange) with the v2.2 Hydrofabric
