-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for IntelliJ 2020.3.2 #22
Conversation
dubinsky
commented
Mar 14, 2021
- Add com.github.ben-manes.versions Gradle plugin;
- Upgrade Gradle to 6.8.3;
- Upgrade org.jetbrains.intellij Gradle plugin to 0.7.2;
- Upgrade org.jetbrains.grammarkit Gradle plugin to 2020.3.2;
- Upgrade PsiViewer plugin to 203-SNAPSHOT;
- Upgrade JUnit to 4.13.2;
- Upgrade Gradle to 6.8.3; - Upgrade org.jetbrains.intellij Gradle plugin to 0.7.2; - Upgrade org.jetbrains.grammarkit Gradle plugin to 2020.3.2; - Upgrade PsiViewer plugin to 203-SNAPSHOT; - Upgrade JUnit to 4.13.2;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks! Please look at the comments below.
.idea/codeStyles/Project.xml
Outdated
<option name="TAB_SIZE" value="2" /> | ||
<option name="USE_TAB_CHARACTER" value="true" /> | ||
<option name="SMART_TABS" value="true" /> | ||
<option name="CONTINUATION_INDENT_SIZE" value="2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry; reverted.
val pluginVersion = if (isCI) "$pluginComingVersion-$commitHash" else pluginComingVersion | ||
val packageName = "org.ice1000.tt" | ||
|
||
group = packageName | ||
version = pluginVersion | ||
|
||
plugins { | ||
id("com.github.ben-manes.versions") version "0.38.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin provides dependencyUpdates
task that lists all the dependencies (including Gradle plugins and Gradle itself) that have later versions than the ones used. It simplifies the version upgrades: one doesn't need to check each dependency manually.
- Upgrade Gradle to 6.8.3; - Upgrade org.jetbrains.intellij Gradle plugin to 0.7.2; - Upgrade org.jetbrains.grammarkit Gradle plugin to 2020.3.2; - Upgrade PsiViewer plugin to 203-SNAPSHOT; - Upgrade JUnit to 4.13.2;
I'm gonna squash this, do you have some last minute comments? |
Squash away :) |
@dubinsky what brings you here? Why are you looking at this project? I'm quite curious :) |
I want to play with Agda, but I do not want to use Emacs. |
The Agda support is very naive. I suggest VSCode with https://github.com/banacorn/agda-mode-vscode |
I think if you're interested you could port the Agda smart support here. @dandoh wanted to do this but I haven't heard from him for almost a year. |
I don't think I can pull this off - IntelliJ plugins are new territory for me... |
It's not hard tbh |