Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for IntelliJ 2020.3.2 #22

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Upgrade for IntelliJ 2020.3.2 #22

merged 2 commits into from
Mar 15, 2021

Conversation

dubinsky
Copy link
Contributor

  • Add com.github.ben-manes.versions Gradle plugin;
  • Upgrade Gradle to 6.8.3;
  • Upgrade org.jetbrains.intellij Gradle plugin to 0.7.2;
  • Upgrade org.jetbrains.grammarkit Gradle plugin to 2020.3.2;
  • Upgrade PsiViewer plugin to 203-SNAPSHOT;
  • Upgrade JUnit to 4.13.2;

- Upgrade Gradle to 6.8.3;
- Upgrade org.jetbrains.intellij Gradle plugin to 0.7.2;
- Upgrade org.jetbrains.grammarkit Gradle plugin to 2020.3.2;
- Upgrade PsiViewer plugin to 203-SNAPSHOT;
- Upgrade JUnit to 4.13.2;
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks! Please look at the comments below.

<option name="TAB_SIZE" value="2" />
<option name="USE_TAB_CHARACTER" value="true" />
<option name="SMART_TABS" value="true" />
<option name="CONTINUATION_INDENT_SIZE" value="2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry; reverted.

val pluginVersion = if (isCI) "$pluginComingVersion-$commitHash" else pluginComingVersion
val packageName = "org.ice1000.tt"

group = packageName
version = pluginVersion

plugins {
id("com.github.ben-manes.versions") version "0.38.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin provides dependencyUpdates task that lists all the dependencies (including Gradle plugins and Gradle itself) that have later versions than the ones used. It simplifies the version upgrades: one doesn't need to check each dependency manually.

- Upgrade Gradle to 6.8.3;
- Upgrade org.jetbrains.intellij Gradle plugin to 0.7.2;
- Upgrade org.jetbrains.grammarkit Gradle plugin to 2020.3.2;
- Upgrade PsiViewer plugin to 203-SNAPSHOT;
- Upgrade JUnit to 4.13.2;
@ice1000
Copy link
Member

ice1000 commented Mar 15, 2021

I'm gonna squash this, do you have some last minute comments?

@ice1000 ice1000 self-assigned this Mar 15, 2021
@dubinsky
Copy link
Contributor Author

I'm gonna squash this, do you have some last minute comments?

Squash away :)

@ice1000 ice1000 merged commit 02fc902 into owo-lang:master Mar 15, 2021
@ice1000
Copy link
Member

ice1000 commented Mar 15, 2021

@dubinsky what brings you here? Why are you looking at this project? I'm quite curious :)

@dubinsky
Copy link
Contributor Author

dubinsky commented Mar 15, 2021

@dubinsky what brings you here? Why are you looking at this project? I'm quite curious :)

I want to play with Agda, but I do not want to use Emacs.
Since I spend my days in IntelliJ, ideally I'd like to use it (and not Atom or VScode) to be my Agda IDE.
Your work is the most updated attempt (of the two I saw) at such a thing...

@ice1000
Copy link
Member

ice1000 commented Mar 15, 2021

@dubinsky what brings you here? Why are you looking at this project? I'm quite curious :)

I want to play with Agda, but I do not want to use Emacs.
Since I spend my days in IntelliJ, ideally I'd like to use it (and not Atom or VScode) to be my Agda IDE.
Your work is the most updated attempt (of the two I saw) at such a thing...

The Agda support is very naive. I suggest VSCode with https://github.com/banacorn/agda-mode-vscode

@ice1000
Copy link
Member

ice1000 commented Mar 15, 2021

I think if you're interested you could port the Agda smart support here. @dandoh wanted to do this but I haven't heard from him for almost a year.

@dubinsky
Copy link
Contributor Author

I think if you're interested you could port the Agda smart support here. @dandoh wanted to do this but I haven't heard from him for almost a year.

I don't think I can pull this off - IntelliJ plugins are new territory for me...

@ice1000
Copy link
Member

ice1000 commented Mar 15, 2021

I think if you're interested you could port the Agda smart support here. @dandoh wanted to do this but I haven't heard from him for almost a year.

I don't think I can pull this off - IntelliJ plugins are new territory for me...

It's not hard tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants