Skip to content

Update: custom props for checkboxes #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Update: custom props for checkboxes #435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d0b45
Update: custom props for fix case use Checkbox as slot in combobox
haild173094 Mar 5, 2025
a9f70ba
Update: comment
haild173094 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/Checkbox/Checkbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ export interface CheckboxProps extends ChoiceBleedProps {
error?: Error | boolean;
/** Indicates the tone of the checkbox */
tone?: 'magic';
/** Disable auto focus to input when click to checkbox*/
disableFocus?: boolean;
}

type CheckboxSlots = {
Expand Down Expand Up @@ -233,7 +235,12 @@ const handleOnClick = () => {
}

model.value = inputNode.value.checked;
inputNode.value.focus();

// Props use for fix case Checkbox use as slot of Combobox Component -> auto close popover when change focus
if (!props.disableFocus) {
inputNode.value.focus();
}

emits('change', inputNode.value.checked, props.value || id.value);
};
</script>