Skip to content

fix: filter chip design #9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix: filter chip design #9543

merged 1 commit into from
Aug 8, 2023

Conversation

JammingBen
Copy link
Contributor

Description

This error only happened on master and when using pnpm build:w. We still need to figure out why CSS properties have different priorities when using pnpm vite and pnpm build.

Broken:
image

Fixed:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 4, 2023
@update-docs
Copy link

update-docs bot commented Aug 4, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JammingBen JammingBen merged commit d021151 into master Aug 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-filter-chip-design branch August 8, 2023 07:32
@grimmoc grimmoc self-requested a review August 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@grimmoc grimmoc Awaiting requested review from grimmoc

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @lookacat