Skip to content

Conversation

@fschade
Copy link
Contributor

@fschade fschade commented Jun 2, 2021

Description

This PR

  • Adds TypeScript support
  • Refactors code, extracts a lot of logic from the store to a shared package
  • Reduces thumbnail sizes (we had huge resolutions for thumbnails before)
  • Introduces image caching (used for avatars and previews for now. not surviving page reloads)
  • Adds a visibility observer which takes care of loading only thumbnails that are close to the user's viewport in the browser

Related Issue

Motivation and Context

Strong types, better project architecture, separation of view logic and business logic, performance improvements

How Has This Been Tested?

  • unit tests

Types of changes

  • New feature (non-breaking change which adds functionality)

@update-docs
Copy link

update-docs bot commented Jun 2, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade self-assigned this Jun 2, 2021
@fschade fschade force-pushed the performance-tasks branch from 05eb5c1 to c2f6949 Compare June 2, 2021 17:29
@fschade fschade force-pushed the performance-tasks branch 2 times, most recently from 4a09d12 to 8b59b1c Compare June 10, 2021 08:00
@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingExternal failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait1-Notifications failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingExternalRoot failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests IntegrationApp2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests oc10-integration-notifications failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests IntegrationApp1 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCIS-Trashbin-Upload-Move-Journey failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingInternalUsers1 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

@fschade fschade force-pushed the performance-tasks branch from 8b59b1c to 0753b0c Compare June 10, 2021 08:08
@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

@pascalwengerter pascalwengerter force-pushed the performance-tasks branch 2 times, most recently from fa3cc36 to a9f71e2 Compare June 10, 2021 15:58
@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16148/

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-61.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-61.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-22.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-22.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-58.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-58.png

💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16149/

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-61.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-61.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-22.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-22.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-42.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-58.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-58.png

💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. The build is cancelled...

@fschade fschade force-pushed the performance-tasks branch 2 times, most recently from f7ef9b7 to 6de0af1 Compare June 16, 2021 11:56
@fschade fschade closed this Jun 16, 2021
@fschade fschade deleted the performance-tasks branch June 16, 2021 11:59
@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingPermissions1 failed. The build is cancelled...

@fschade fschade force-pushed the performance-tasks branch from 63f99dd to 248f921 Compare June 17, 2021 16:27
@ownclouders
Copy link
Contributor

💥 Acceptance tests IntegrationApp2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests IntegrationApp2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests ResharingToRoot failed. The build is cancelled...

@pascalwengerter pascalwengerter changed the title Various performance and structure optimizations [full-ci] Various performance and structure optimizations Jun 17, 2021
@pascalwengerter pascalwengerter requested a review from kulmann June 17, 2021 17:05
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16488/

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16497/

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

50.3% 50.3% Coverage
8.7% 8.7% Duplication

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome enhancements and bugfixes. Thank you for fighting through this! ❤️ 💪

@kulmann kulmann merged commit 4e1955d into master Jun 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the performance-tasks branch June 18, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request cancelation Send avatar requests in the background Cache for avatars

5 participants