Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graph JSON error capitalization #8733

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Mar 26, 2024

Description

change the graph service json error messages to be capitalized by default.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

change the graph service json error messages to be capitalized by default.
Copy link

@fschade
Copy link
Contributor Author

fschade commented Mar 26, 2024

i keep that open for now, we have to all agree if we wanna have user facing errors uppercase or not or better creat a translation dictionary.

If we decide to have it that way we need to fix:

the related issue:
#8624

@JammingBen can you explain why that is important for the web frontend?

@fschade fschade marked this pull request as draft March 26, 2024 10:02
@JammingBen
Copy link
Contributor

@JammingBen can you explain why that is important for the web frontend?

It's not that important, I just thought it would be easy to fix it. But if that's not the case, Web can always capitalize the message on its own.

@fschade fschade self-assigned this Mar 27, 2024
@fschade fschade added the Status:Needs-Revision Needs code input from a maintainer label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Revision Needs code input from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ocis][Sharing NG] Banned link password error message capitalization
2 participants