dig into http2 support #5866
Closed
dig into http2 support #5866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
💥 Acceptance test localApiTests-apiArchiver-ocis failed. Further test are cancelled... |
Member
Author
|
I am no longer working on this. Feel free to pick it up. I'll happily review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging into #5116 out of curiosity.
AFAICT just instanting tls.Config or even setting some params will break http2 support. I got http2 working (partially) by manually setting
NextProtos: []string{"h2", "http/1.1"},... but things are a little more complicated as we also need to tell the go micro servers and clients to use a Transport with http2 support:micro.Transport(transport.NewHTTPTransport(transport.TLSConfig(sopts.TLSConfig)))We are also manually adding a
use_tlsflag to the micro metadata, which the proxy evaluates to either send http or http2 requests ... IMO that should be handled by the micro registry ...Furthermore, reva also needs some changes: cs3org/reva#3736
In any case this needs more digging