ship old Nextcloud Mapper to support NC 26+ #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
a3linux
approved these changes
Mar 23, 2023
|
Tested such functions on Nextcloud 26.0
|
|
Great, thanks! I'll try to look into this within the next few days. |
|
Also upgraded my instance today and patched music with this. My key use case, subsonic via DSub, is working :) |
|
Thank you, nice job. |
|
Nice job working |
|
Would be nice to see this merged. |
PHPStan cannot pick up any class_alias definitions from the code to be analyzed and was producing a lot of errors. Giving the alias in a specific bootstrap file configured for PHPStan solves the issue. Also, PHPStan was complaining about an unnecessary sanity check in OldNextcloudMapper. This was set to be ignored because the check was pointless only if you believe that the type hints given as PHPDoc can never be broken.
|
The inspection completed: 123 new issues, 14 updated code elements |
|
Seems to work fine on various versions of ownCloud, too. I made a few cosmetic changes to make it ready for merging. |
|
Thank you @paulijar! |
Closed
|
@Ana-Khouri No promises, but I hope that I get the release done this week. |
|
The release v1.8.2 with this support for NC26 is now out! |
|
🔥 Thanks ! @paulijar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1050
Ships
lib/public/AppFramework/Db/Mapper.phpfrom Nextcloud 25 with adjusted namespace. Upon app init, an alias is created toOCA\Music\Db\CompatibleMapperwhich is used later on, instead of directly referencing\OCP\AppFramework\Db\Mapper.Tested successfully on both my dev setups of NC 25 and NC 26.