Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hint user in share dialog about password policy #41314

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 2, 2024

Description

Add hint about password policy

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link

update-docs bot commented Sep 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Sep 2, 2024

@DeepDiver1975 DeepDiver1975 merged commit 6f45e48 into master Sep 2, 2024
5 checks passed
@DeepDiver1975 DeepDiver1975 deleted the fix/i18h-choose-pwd branch September 2, 2024 14:36
@dj4oC
Copy link

dj4oC commented Sep 3, 2024

Enquiry from the customer: Is it possible to do this in such a way that you can then include a custom string from an .env that describes the policy?
image

Ideally with the option of being able to ‘unhide’ the password

@DeepDiver1975
Copy link
Member Author

Technically this is possible - but this is a new feature and we do no new features .... 🤷

@dj4oC
Copy link

dj4oC commented Sep 3, 2024

fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String modification for better understanding
3 participants