Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Remove remaining ocis related code #40632

Merged
merged 1 commit into from
Feb 10, 2023
Merged

[tests-only][full-ci] Remove remaining ocis related code #40632

merged 1 commit into from
Feb 10, 2023

Conversation

roshanlc
Copy link

Description

This PR removes any remaining OCIS related code from core tests.
It depends upon PR #40629

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@roshanlc roshanlc mentioned this pull request Feb 10, 2023
Merged
11 tasks
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roshanlc roshanlc marked this pull request as ready for review February 10, 2023 09:49
individual-it
individual-it approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I think the getPersonalSpaceIdForUser() functions can also be deleted or changed, because OC10 does not have any spaces.
But that can be done in a separate PR

@individual-it individual-it merged commit b7569ed into owncloud:master Feb 10, 2023
@roshanlc roshanlc deleted the remove-ocis-related-code branch February 15, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@roshanlc roshanlc

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roshanlc @individual-it @SwikritiT