Add when step to create new regular user using api for the acceptance tests #36724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasson99
force-pushed
the
createRegularUserWithSameEmailAddressOfGuestUser
branch
from
d068ded
to
528870f
Compare
Codecov Report
@@ Coverage Diff @@
## master #36724 +/- ##
=========================================
Coverage 64.68% 64.68%
Complexity 19118 19118
=========================================
Files 1269 1269
Lines 74775 74775
Branches 1320 1320
=========================================
Hits 48369 48369
Misses 26018 26018
Partials 388 388
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Instead of adding when you can split given-when like @kiranparajuli589 did
jasson99
force-pushed
the
createRegularUserWithSameEmailAddressOfGuestUser
branch
3 times, most recently
from
248077c
to
3f7e901
Compare
|
Suggestion: Change the description and mention the related issues, PRs |
jasson99
changed the title
jasson99
changed the title
jasson99
changed the title
phil-davis
reviewed
Jan 9, 2020
| @@ -365,6 +365,7 @@ public function theseUsersHaveBeenCreatedWithoutSkeletonFiles(TableNode $table) | |||
|
|
|||
| /** | |||
| * @Given /^these users have been created with ?(default attributes and|) skeleton files ?(but not initialized|):$/ | |||
| * @When /^the administrator creates a regular user with ?(default attributes and|) skeleton files ?(but not initialized|):$/ | |||
There was a problem hiding this comment.
Suggested change
| * @When /^the administrator creates a regular user with ?(default attributes and|) skeleton files ?(but not initialized|):$/ | |
| * @When /^the administrator creates these users with ?(default attributes and|) skeleton files ?(but not initialized|):$/ |
At the moment it sounds like no table is required. But actually this step has to have a table of users, and it can have 1 or many users that can have any user names.
jasson99
force-pushed
the
createRegularUserWithSameEmailAddressOfGuestUser
branch
from
3f7e901
to
42e413e
Compare
phil-davis
approved these changes
Jan 9, 2020
delete-merged-branch
bot
deleted the
createRegularUserWithSameEmailAddressOfGuestUser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add when step to create a new regular user in the acceptance tests.
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: