Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust .github files #36440

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Adjust .github files #36440

merged 1 commit into from
Nov 19, 2019

Conversation

phil-davis
Copy link
Contributor

Description

  1. minor grammar error in CONTRIBUTING.md
  2. don't need to talk specifically about "next major version" - we use semver and the next version number is whatever it will be. Don't need to mention backporting.
  3. In issue_template.md don't need to mention about "your major branch..."

Motivation and Context

I noticed this stuff while adding these files to an app.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #36440 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36440      +/-   ##
============================================
+ Coverage     65.05%   65.16%   +0.11%     
  Complexity    19802    19802              
============================================
  Files          1271     1271              
  Lines         74754    74754              
  Branches       1309     1309              
============================================
+ Hits          48629    48712      +83     
+ Misses        25739    25656      -83     
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.38% <ø> (+0.12%) 19802 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...private/DB/MySqlSchemaColumnDefinitionListener.php 78.94% <0%> (+72.8%) 46% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656db9e...c46f29b. Read the comment docs.

@phil-davis phil-davis merged commit 02f6104 into master Nov 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the adjust-dot-github-files branch November 19, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants