Skip to content

Fix overlapping selectively in default fileslist #28872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2017
Merged

Fix overlapping selectively in default fileslist #28872

merged 1 commit into from
Sep 4, 2017

Conversation

@felixheidecke
Copy link
Contributor

@felixheidecke felixheidecke commented Aug 31, 2017

Description

Scope changes previously done in #28678 to the default files-list view only.
Aka: #app-content-files

Related Issue

Fixes #28850
Fixes https://github.com/owncloud/enterprise/issues/2068

How Has This Been Tested?

Visual test in FF, Chrome & IE11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felixheidecke felixheidecke added Type:Bug p1-urgent Critical issue, need to consider hotfix with just that issue regression sev1-critical labels Aug 31, 2017
@felixheidecke felixheidecke added this to the development milestone Aug 31, 2017
@haukman
Copy link

haukman commented Sep 1, 2017

I can verify that it looks ok for the files app and is not doing anything in the "shared with me" section.

@felixheidecke felixheidecke force-pushed the fh-fix_broken-trashbin-layout branch from 3053961 to e213b21 Compare September 4, 2017 12:01
@felixheidecke
Copy link
Contributor Author

felixheidecke commented Sep 4, 2017

@haukman and @PVince81 … This works now ;-)

@felixheidecke
Fix overlapping selectively in default fileslist
9c8cf01 
Fix overlapping selectively in default fileslist

Include sharing- in and -out

Revert: Correcting CSS selector (.htaccess)
@felixheidecke felixheidecke force-pushed the fh-fix_broken-trashbin-layout branch from e213b21 to 9c8cf01 Compare September 4, 2017 12:05
@haukman
Copy link

haukman commented Sep 4, 2017 •
edited by PVince81
Loading

stupid question: Will this be part of 10.0.3 or 10.0.4?

@PVince81
Copy link
Contributor

PVince81 commented Sep 4, 2017

This works now ;-)

@felixheidecke retested in all browsers ?

@felixheidecke
Copy link
Contributor Author

felixheidecke commented Sep 4, 2017

Looks good from here ;-)
bildschirmfoto 2017-09-04 um 16 41 34

@PVince81 PVince81 merged commit eb3d01a into master Sep 4, 2017
@PVince81 PVince81 deleted the fh-fix_broken-trashbin-layout branch September 4, 2017 16:16
@PVince81
Copy link
Contributor

PVince81 commented Sep 4, 2017

@felixheidecke please backport to table10.

@haukman aiming for 10.0.3

@phil-davis phil-davis mentioned this pull request Sep 5, 2017
Merged
@phil-davis
Copy link
Contributor

phil-davis commented Sep 5, 2017

Backport stable10 #28906
@felixheidecke I did this backport for you, to save European office time.
Note that some of the diffs here in master were already in stable10 correctly. So the diff of the backport has less lines. The cherry-pick did its thing correctly and automatically.

@felixheidecke felixheidecke mentioned this pull request Sep 7, 2017
Closed
9 tasks
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PVince81 PVince81 Awaiting requested review from PVince81

@haukman haukman Awaiting requested review from haukman

Assignees

@felixheidecke felixheidecke

Labels

4 - To release p1-urgent Critical issue, need to consider hotfix with just that issue regression sev1-critical status/STALE Type:Bug

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

Broken trashbin layout

7 participants

@felixheidecke @haukman @PVince81 @phil-davis @DeepDiver1975 @ownclouders