Skip to content

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Feb 23, 2017

  • Added make test-js-debug for @felixheidecke for debugging test JS without having to type the whole obscure karma command
  • Added make help with most common commands
  • Changed "getcomposer.sh" to use local composer when available: to avoid hammering their servers and also saves bandwidth

@DeepDiver1975 @jvillafanez @VicDeo please review

Vincent Petry added 2 commits February 23, 2017 10:14
Runs karma in continuous mode which makes it possible to debug in one
or multiple browsers
@PVince81 PVince81 added this to the 10.0 milestone Feb 23, 2017
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @jnweiger and @dragotin to be potential reviewers.

@PVince81
Copy link
Contributor Author

Weird, seems that using the local composer doesn't work at all... I should have tested this

@PVince81
Copy link
Contributor Author

Ah never mind... My composer script was a shell script, not the phar file. Works now.

@PVince81
Copy link
Contributor Author

Seems to fail for the Travis shim... Oh well, I guess I'll remove that bit then.

@PVince81
Copy link
Contributor Author

Removed local composer detection for now.

@DeepDiver1975 DeepDiver1975 merged commit 7d71f80 into master Mar 1, 2017
@DeepDiver1975 DeepDiver1975 deleted the makefile-help branch March 1, 2017 10:17
IljaN pushed a commit that referenced this pull request Mar 1, 2017
* Add make test-js-debug for continuous testing

Runs karma in continuous mode which makes it possible to debug in one
or multiple browsers

* Add make help command
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants