Use clearer name setUpScenario #27189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phil-davis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @PVince81 and @SergioBertolinSG to be potential reviewers. |
SergioBertolinSG
approved these changes
Feb 21, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name tearUpScenario was confusing when I was looking at how some existing tests were set up. In English, "tear up" is what you do with a printed contract when you do not like it! It is a destructive thing.
Rename it to setUpScenario
Related Issue
#27188
Motivation and Context
Reduce confusion for developers/users that are learning the test infrastructure.
How Has This Been Tested?
The automated tests should still run fine when I press "Create pull request" in a moment.
Screenshots (if appropriate):
Types of changes
Checklist: