Creating second share to user who renamed received folder creates a second entry#25568
Merged
DeepDiver1975 merged 2 commits intomasterfrom Jul 26, 2016
Merged
Creating second share to user who renamed received folder creates a second entry#25568DeepDiver1975 merged 2 commits intomasterfrom
DeepDiver1975 merged 2 commits intomasterfrom
Conversation
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @SergioBertolinSG, @rullzer and @LukasReschke to be potential reviewers |
This was referenced Jul 22, 2016
In some situations, a group share is created before a user share, and the recipient renamed the received share before the latter is created. In this situation, the "file_target" was already modified and the second created share must align to the already renamed share. To achieve this, the MountProvider now groups only by "item_source" value and sorts by share time. This makes it so that the least recent share is selected as super-share and its "file_target" value is then adjusted in all grouped shares. This fixes the issue where this situation would have different "file_target" values resulting in two shared folders appearing instead of one.
Contributor
Author
Contributor
Author
|
TODOs after merge:
|
Contributor
|
@PVince81 yes that is the correct usage. 👍 |
Contributor
Author
|
@DeepDiver1975 can the Jenkinsfile thing be ignored ? If yes, please merge. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps
Expected result
Only one folder "test_renamed" appear
Actual result
Two folders, "test" and "test_renamed".
Also happens when sharing first with "user1" and "group1"
Versions
Regression since OC 9.0, works fine in OC 8.2.7.
This PR brings an integration test to cover this case.
On master there were fixes regarding to grouping for #24575 but they failed to cover this specific case.
Let's address this inside this PR.
@owncloud/sharing