Fix getting the certificate bundle for dav external storage #25274
Conversation
|
By analyzing the blame information on this pull request, we identified @schiessle, @PVince81 and @nickvergessen to be potential reviewers |
| * which might be temporary | ||
| */ | ||
| private function convertException(Exception $e, $path = '') { | ||
| \OC::$server->getLogger()->logException($e); |
There was a problem hiding this comment.
hmm, I thought we logged the exception already later
There was a problem hiding this comment.
From what I can tell we log the converted exception in some cases.
Having the original exception makes it easier to track down the cause
|
Code looks good 👍 |
| } | ||
| if ($this->secure === true) { | ||
| // inject mock for testing | ||
| $certPath = \OC_User::getHome(\OC_User::getUser()) . '/files_external/rootcerts.crt'; |
There was a problem hiding this comment.
are there any migration steps required to move this file around?
There was a problem hiding this comment.
the path returned should be the same.
I think the issue I ran into was the cert bundle not yet being created for the user, using the cert manager makes sure things like that are all taken care off
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Required in (some?) cases to get fed. sharing working with self-signed certificates
cc @owncloud/filesystem