Login hooks

[ChristophWurst]

I found an inconsistency of login hooks while working on #25154.

1. hooks were triggered twice (once in login and then in loginWithToken)
2. the post login hook in login was called without tranlating a possible token password to the login password
3. when logging in a disabled user via token no LoginException was thrown (the login was still blocked, but resulted in a 401 instead)
4. when logging in via token there was no check whether an app aborted the login process via the post login hook

Needs rebase once #25154 was merged. done

[mention-bot]

By analyzing the blame information on this pull request, we identified @icewind1991, @DeepDiver1975 and @blizzz to be potential reviewers

[ChristophWurst]

Note for reviewers: loginByPassword handles the process of logging in by password, loginByToken handles the token login process. Hence they should perform the same checks.

[ChristophWurst]

• TEST: LoginException is thrown in case a user was disabled
• TEST: login with password works
• TEST: login with token works
• TEST: preLogin hook triggered for password logins
• TEST: preLogin hook triggered for token logins
• TEST: postLogin hook triggered for password logins
• TEST: postLogin hook triggered for token logins

[guruz]

Code looks OK, I have not tested it.
👍

[ChristophWurst]

this fixes token login for clients, which seems to have issues on current master (see failing integration tests of other PRs). @DeepDiver1975 @PVince81 @icewind1991 review please

[ChristophWurst]

the return statement is missing on master, hence the return false; below is executed and the login is considered to have failed.

[ChristophWurst]

PHPDoc added and postLogin hook moved accordingly.

[PVince81]

👎 looks like token auth is broken. Works fine on master.

[PVince81]

Wait, I forgot to pull

[PVince81]

Tested with ext storage that uses post login for user provided creds (had to rebase onto master for that), both password and token login work and the ext storage can be accessed in both cases

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.