Add a warning when the transaction isolation level is not READ_COMMITED #24889
Conversation
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975, @LukasReschke and @jancborchardt to be potential reviewers |
| /** @var \Doctrine\DBAL\Connection $connection */ | ||
| $connection = \OC::$server->getDatabaseConnection(); | ||
| try { | ||
| $template->assign('invalidTransactionIsolationLevel', $connection->getTransactionIsolation() !== \Doctrine\DBAL\Connection::TRANSACTION_READ_COMMITTED); |
There was a problem hiding this comment.
Is this required for all dbms or only mysql?
There was a problem hiding this comment.
It is required for all that have a transaction isolation level:
Postgres: https://www.postgresql.org/docs/current/static/transaction-iso.html
Oracle: http://docs.oracle.com/cd/E11882_01/server.112/e41084/statements_10005.htm#SQLRF01705
Can't find exact docs for sqlite, it seems to have a boolean for "read uncommited" instead.
So I guess I will disable it for sqlite
|
We should backport this to all stable releases |
nickvergessen
force-pushed
the
add-warning-wrong-transaction-isolation-level
branch
from
f885b60
to
4da5a74
Compare
|
👍 |
1 similar comment
|
👍 |
|
@nickvergessen please submit the backport PRs, thanks CC @cmonteroluque @DeepDiver1975 |
|
thanks @nickvergessen |
ghost
mentioned this pull request
|
Ref to the doc part: owncloud-archive/documentation#2477 There definitely will be questions about that coming up |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ref #24882
@PVince81 @DeepDiver1975