Add OCS API to send, get, accept and decline remote shares

[nickvergessen]

This is required so we can manage remote shares via the pyoc client for smashbox

Replace #14668
Fix #13627

[karlitschek]

super cool!!! 👍

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/12687/
🚀 Test PASSed.🚀

[nickvergessen]

@schiesbn mind having a look at the URL and stuff? Thanks

[schiessle]

looks good 👍

[nickvergessen]

@rullzer are you okay with the direction as well? I want to get this in, as soon as 8.1 is out, so we can have all the smashbox tests with server2server share from the beginning of the 8.2 dev cycle

[rullzer]

Yep looking good! 👍

[rullzer]

Rebase of course ;)

[scrutinizer-notifier]

A new inspection was created.

[nickvergessen]

rebased cleanly
no idea what was wrong that it couldn't be merged before.

[ghost]

🚀 Test PASSed.🚀

[rullzer]

Would it be possible to add some tests here?
Maybe just inject some stuff in the database and see if this retrieves it clearly etc..

[nickvergessen]

Well the methods are tested in https://github.com/owncloud/core/blob/master/apps/files_sharing/tests/external/managertest.php ;)

[rullzer]

Ah great! Lets merge this baby then, so smashbox can do its thing and break ;)

[PVince81]

@nickvergessen Do we want to backport this ?

[nickvergessen]

No, if so we should have merged it before the release.. this is a new feature

[PVince81]

Fine by me, makes sense.

[jnfrmarks]

@nickvergessen

Is there any doc for the new apis?

[nickvergessen]

It's OCS, what doc do you need? the URLs or what?

If you can point me to other OCS api docs I can prepare a PR

[jnfrmarks]

Are there new apis to support the remote shares or is this change an extension of the existing api?

[PVince81]

The OCS docs for sharing are here: https://github.com/owncloud/documentation/blob/master/developer_manual/core/ocs-share-api.rst

So I guess you could update them ?

[nickvergessen]

@jnfrmarks this just adds a non-UI way for remote shares, so we can use them in smashbox to test federated cloud sharing

[nickvergessen]

Documentation PR at owncloud-archive/documentation#1329

Feel free to review