allow configuring oracle session mode, needed when using oracle wallet #16266

butonic · 2015-05-12T09:08:30Z

@bboule can you test this in the lab? It seems without it oracle wallet cannot be used. In config.php set

  'dbsessionmode' => OCI_CRED_EXT,
  'dbuser' => '/',
  'dbpass' => '',
  'dbname' => 'YOUR_WALLET_NAME',

Followup tasks:

installer ui to allow using wallet during installation.
add option to the console setup command
sample documentation
report upstream bug regarding upgrade issue @butonic

see http://stackoverflow.com/a/11644451

cc @CaptionF

ghost · 2015-05-12T10:00:54Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/12284/
🚀 Test PASSed.🚀

bboule · 2015-05-12T10:38:57Z

I can I have this set up just need to carve out the time I was under the impression that wallet was simply called by tnsnames let me dig in with my instance today

Sent from my iPhone

On May 12, 2015, at 5:08 AM, Jörn Friedrich Dreyer notifications@github.com wrote:

@bboule can you test this in the lab? It seems without it oracle wallet cannot be used. In config.php set

'dbsessionmode' => OCI_CRED_EXT,
'dbuser' => '/',
'dbpass' => '',
'dbname' ’> 'YOUR_WALLET_NAME',
Followup tasks:

installer ui to allow using wallet during installation.
sample documentation
see http://stackoverflow.com/a/11644451

cc @CaptionF

You can view, comment on, or merge this pull request online at:

#16266

Commit Summary

allow configuring oracle session mode, needed when using oracle wallet
File Changes

M lib/private/db/connectionfactory.php (5)
Patch Links:

https://github.com/owncloud/core/pull/16266.patch
https://github.com/owncloud/core/pull/16266.diff
—
Reply to this email directly or view it on GitHub.

DeepDiver1975 · 2015-05-19T10:12:03Z

setting this as 'Developing' since there are open todos

DeepDiver1975 · 2015-06-01T13:11:28Z

@butonic what shall we do this this?

LukasReschke · 2015-06-05T20:11:24Z

lib/private/db/connectionfactory.php

@@ -184,6 +184,11 @@ public function createConnectionParams($config) {
 		if ($driverOptions) {
 			$connectionParams['driverOptions'] = $driverOptions;
 		}
+		// allow setting oracle session mode parameter, eg OCI_CRED_EXT when using oracle wallet
+		$sessionMode = $config->getValue('dbsessionmode', null);
+		if ($sessionMode) {


I wonder if it would not make more sense if we just add a connectionParams array to our config and merge it together. Otherwise for each special wish we're adding not really tested and used option switches.

Wishful thinking, unfortunately. The adapters in doctrine already treat $driverOptions (which I had hoped could be used for this) differently:

Oracle ignores them and intead uses the $params array: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/OCI8/Driver.php#L44

MySQL (PDO) uses them: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/PDOMySql/Driver.php#L44

PgSqL (PDO) uses them: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/PDOPgSql/Driver.php#L45

MySQLi uses the options https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/Mysqli/MysqliConnection.php#L62 and ultimately https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/Mysqli/MysqliConnection.php#L214

Sqlite (PDO) uses them, but removes userDefinedFunctions: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php#L59

SQLSrv uses it as the array used for the actual connection: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/SQLSrv/Driver.php#L44 and oltimately https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/SQLSrv/SQLSrvConnection.php#L55

So the correct fix IMO would be to make the doctrine oracle client aware of the $driverOptions. A quick search did not give a good result. Something like http://www.doctrine-project.org/jira/browse/DBAL-643?jql=text%20~%20%22driveroptions%22 but for oracle.

butonic · 2015-06-22T13:02:05Z

prooved working at the customer. need to find out why I keep running into ORA-12578: TNS:wallet open failed

ma-schmid · 2015-07-06T08:24:10Z

Support of Linux distribution assumes, that ORACLE_HOME is hard coded in OCI extension:
there are 2 options to solve this:
a) to use sym link in /usr/lib64 to ORACLE_HOME
b) using environment vars in each php script

b) might be a upgrade / patch hell

What are we recommending ? Please advice!
@butonic @bboule

ma-schmid · 2015-07-06T08:33:57Z

Solution provided by contact:

LD_LIBRARY_PATH has been set system wide by creating a file in /etc/ld.so.conf.d/ with a path to ORACLE_HOME.
With ldconfig the LD_LIBRARY_PATH will be extended and the system will search also for libraries.
ORACLE_HOME is defined in apache Vhost Config (Setenv).
With this config, Oracle Wallet works without any symlinks in /usr/lib64.

@butonic @bboule please validate and hand over to documentation / carla

DeepDiver1975 · 2015-08-10T22:44:22Z

Can we please have feedback on this one? @butonic @bboule @CaptionF - THX

butonic · 2015-08-12T08:56:10Z

Feedback on what exactly? The PR allows using oracle wallet as confirmed at the customer. @CaptionF gave feedback on the ORACLE_HOME setup. An I responded to the totally valid comment of @LukasReschke.

The todos are still open. The question is who is going to implement them. Maybe @tariqsiddiqui ?

DeepDiver1975 · 2015-08-12T08:59:49Z

Feedback on what exactly?

does it work?
who will take care about the open tasks

DeepDiver1975 · 2015-08-12T09:00:18Z

If you want this in for 8.2 - please take action - otherwise I need to move this to 8.3

bboule · 2015-08-12T11:40:40Z

Hey Guys... it is important that this is in 8.2 what exactly needs to be done here? We can confirm this does indeed work what exactly would we need @tariqsiddiqui to do?

DeepDiver1975 · 2015-08-12T11:44:27Z

what exactly would we need @tariqsiddiqui to do?

There are 3 open tasks in the description of this pr - #16266 (comment)

We can confirm this does indeed work

Great - THX

DeepDiver1975 · 2015-10-05T11:10:40Z

After talking with @butonic we decided to move this to 9.0 because this is not yet production ready.
There is an open issue which we need to get fixed upstream (doctrine) otherwise upgrades will not work.

DeepDiver1975 · 2015-10-05T12:12:14Z

After talking with @butonic we decided to move this to 9.0 because this is not yet production ready.
There is an open issue which we need to get fixed upstream (doctrine) otherwise upgrades will not work.

@karlitschek @cmonteroluque @MTRichards FYI

ghost · 2015-10-05T20:06:07Z

@bboule FYI

PVince81 · 2015-11-20T10:33:04Z

Is the upstream issue still there ? Is there a direct link or should we submit one ?

DeepDiver1975 · 2015-11-20T10:41:58Z

Is the upstream issue still there ? Is there a direct link or should we submit one ?

@butonic

butonic · 2015-11-20T12:50:52Z

We need to submit one. #16266 (comment) is the most detail we currently have. I would have to debug the problem again to fully understand why this problem exists with oracle wallet. I would have to debug the problem again to fully understand why this problem exists with oracle wallet. But I won't find the time in the next 3 weeks.

DeepDiver1975 · 2015-11-25T16:03:32Z

But I won't find the time in the next 3 weeks.

pretty critical then - 9.0 will be in feature freeze beginning of January .... let's see

butonic · 2015-12-09T08:22:14Z

will not be able to work on this before january

DeepDiver1975 · 2015-12-09T10:14:30Z

will not be able to work on this before january

Lucky you there will be more time for 9.0 in January 😉

MorrisJobke · 2016-01-15T14:06:09Z

@butonic Ping :)

butonic · 2016-02-17T12:36:17Z

commited patch upstream: doctrine/dbal#2318

MorrisJobke · 2016-03-04T15:45:29Z

commited patch upstream: doctrine/dbal#2318

Pinged upstream - but this PR need to wait for 9.1

butonic · 2016-03-04T18:42:01Z

alternate approach as suggested by upstream is in doctrine/dbal#2325 but needs review. @MorrisJobke thx for weighing in.

DeepDiver1975 · 2016-04-12T12:32:56Z

@butonic can we delete the branch? THX

lock · 2019-08-06T13:01:36Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

DeepDiver1975 added this to the 8.1-current milestone May 12, 2015

ma-schmid assigned bboule May 16, 2015

DeepDiver1975 added 3 - To Review 2 - Developing and removed 3 - To Review labels May 19, 2015

DeepDiver1975 modified the milestones: 8.2-next, 8.1-current Jun 1, 2015

LukasReschke reviewed Jun 5, 2015
View reviewed changes

allow configuring oracle session mode, needed when using oracle wallet

921edab

DeepDiver1975 force-pushed the alleowconfiguringoraclesessionmode branch from 5f2043f to 921edab Compare September 18, 2015 15:27

DeepDiver1975 modified the milestones: 9.0-next, 8.2-current Oct 5, 2015

butonic assigned butonic and unassigned bboule Oct 5, 2015

PVince81 added the db:oracle label Nov 20, 2015

butonic added the blue-ticket label Dec 9, 2015

butonic removed their assignment Dec 9, 2015

DeepDiver1975 modified the milestones: 9.1-next, 9.0-current Dec 9, 2015

bboule assigned butonic Jan 4, 2016

bboule added the Waiting Internal label Jan 22, 2016

MorrisJobke modified the milestones: 9.1-next, 9.0-current Mar 4, 2016

butonic mentioned this pull request Apr 12, 2016

map oracle driver options to params #23938

Merged

butonic closed this Apr 12, 2016

butonic deleted the alleowconfiguringoraclesessionmode branch April 12, 2016 12:38

lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow configuring oracle session mode, needed when using oracle wallet #16266

allow configuring oracle session mode, needed when using oracle wallet #16266

butonic commented May 12, 2015

ghost commented May 12, 2015

bboule commented May 12, 2015

DeepDiver1975 commented May 19, 2015

DeepDiver1975 commented Jun 1, 2015

LukasReschke Jun 5, 2015

butonic Jun 8, 2015

butonic commented Jun 22, 2015

ma-schmid commented Jul 6, 2015

ma-schmid commented Jul 6, 2015

DeepDiver1975 commented Aug 10, 2015

butonic commented Aug 12, 2015

DeepDiver1975 commented Aug 12, 2015

DeepDiver1975 commented Aug 12, 2015

bboule commented Aug 12, 2015

DeepDiver1975 commented Aug 12, 2015

DeepDiver1975 commented Oct 5, 2015

DeepDiver1975 commented Oct 5, 2015

ghost commented Oct 5, 2015

PVince81 commented Nov 20, 2015

DeepDiver1975 commented Nov 20, 2015

butonic commented Nov 20, 2015

DeepDiver1975 commented Nov 25, 2015

butonic commented Dec 9, 2015

DeepDiver1975 commented Dec 9, 2015

MorrisJobke commented Jan 15, 2016

butonic commented Feb 17, 2016

MorrisJobke commented Mar 4, 2016

butonic commented Mar 4, 2016

DeepDiver1975 commented Apr 12, 2016

lock bot commented Aug 6, 2019

allow configuring oracle session mode, needed when using oracle wallet #16266

allow configuring oracle session mode, needed when using oracle wallet #16266

Conversation

butonic commented May 12, 2015

ghost commented May 12, 2015

bboule commented May 12, 2015

DeepDiver1975 commented May 19, 2015

DeepDiver1975 commented Jun 1, 2015

LukasReschke Jun 5, 2015

Choose a reason for hiding this comment

butonic Jun 8, 2015

Choose a reason for hiding this comment

butonic commented Jun 22, 2015

ma-schmid commented Jul 6, 2015

ma-schmid commented Jul 6, 2015

DeepDiver1975 commented Aug 10, 2015

butonic commented Aug 12, 2015

DeepDiver1975 commented Aug 12, 2015

DeepDiver1975 commented Aug 12, 2015

bboule commented Aug 12, 2015

DeepDiver1975 commented Aug 12, 2015

DeepDiver1975 commented Oct 5, 2015

DeepDiver1975 commented Oct 5, 2015

ghost commented Oct 5, 2015

PVince81 commented Nov 20, 2015

DeepDiver1975 commented Nov 20, 2015

butonic commented Nov 20, 2015

DeepDiver1975 commented Nov 25, 2015

butonic commented Dec 9, 2015

DeepDiver1975 commented Dec 9, 2015

MorrisJobke commented Jan 15, 2016

butonic commented Feb 17, 2016

MorrisJobke commented Mar 4, 2016

butonic commented Mar 4, 2016

DeepDiver1975 commented Apr 12, 2016

lock bot commented Aug 6, 2019