remove undefined function FileList.finishDelete #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@owncloud/core-developers please review |
|
I just had a look at the code. You can probably remove more depreciated code. All the FileList.deleteFiles stuff is no longer needed since we removed the undo operation for the delete operation in favour of the trash bin. |
|
We shouldn't remove that code. We should eventually bring back undo support: #1266 (comment) Just comment it out. |
|
👍 |
butonic
added a commit
that referenced
this pull request
Feb 9, 2013
remove undefined function FileList.finishDelete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1540
@Raydiation @georgehrke @bartv2 THX