Keep shares when deleting shared folders

[PVince81]

The share entries will be linked with the fileid while they are kept in
the trashbin.

In the future a background just will scrape orphaned shares and delete
them.

(implementing a "new" feature by just deleting code!)

• Needs Delete orphaned shares in a background job #14676 first
• fix unit test

[PVince81]

This will make it possible to keep shares when restoring files from the trashbin.
Please note that it will not work with external storages because in that case the fileid is not kept.

[karlitschek]

as discussed 👍

[karlitschek]

@schiesbn @DeepDiver1975 who can help to review this?�

[PVince81]

This cannot be reviewed yet, the other part #14676 must be merged first, else it won't work.

[PVince81]

@jnfrmarks small heads up for this "feature"

[PVince81]

I'll rebase this now that the blocking ticket was merged.

[PVince81]

How nice, removing code doesn't break any unit tests, maybe there weren't any for that case in the first place.

Please review @DeepDiver1975 @LukasReschke @nickvergessen @MorrisJobke

To test:

1. Share a file or folder with another user
2. Delete the shared file/folder
3. Restore it from trash
4. Reload the page (to refresh the cached shares)
5. See that the file/folder are still shared

Then: same as 2 but delete the parent folder of the shared file/folder.

[MorrisJobke]

Tested and works. Also the shares are not available for the time they are in the trashbin. 👍

[schiessle]

declaration of $toRemove at the top is no longer needed and can be removed too

[schiessle]

beside the comment above 👍

[DeepDiver1975]

nice - the orphant tests are failing again:

Test Result (2 failures / +2)

    Test\BackgroundJob\DeleteOrphanedSharesJobTest.testClearShares
    Test\BackgroundJob\DeleteOrphanedSharesJobTest.testKeepNonFileShares

[PVince81]

Weeeeird. I'll check that again locally (tests ran for me before I pushed)

[PVince81]

Grrrr works locally even when merged with master.

@owncloud-bot retest this please

[PVince81]

Maybe the test order was different and somehow the trashbin didn't get disabled properly for those tests

[scrutinizer-notifier]

A new inspection was created.

[PVince81]

Let's hope this can help: 5803a1f

According to @schiesbn, disabling the trashbin app might not be enough, stuff might still be registered.

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11372/
🚀 Test PASSed.🚀

[PVince81]

@DeepDiver1975 works now.

This needs a second reviewer. Thanks.

[MorrisJobke]

@PVince81 My 👍 still applies. It works as planned here

[PVince81]

I'll update the wiki page with this new "feature"