Groupmanagers displayNamesInGroup should actually search in displaynames #15169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altough more are required to make sure this does not happen again
* Fix for #6967
|
The inspection completed: 4 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
@icewind1991 @PVince81 @DeepDiver1975 could you have a look if the patch makes any sense? |
|
Looks good to me |
|
@rullzer still WIP? THX |
rullzer
changed the title
|
@DeepDiver1975 ah forgot that one. No it should be ready for review now. Unit tests were already in place but just testing the wrong thing. I think this is fine now. |
|
@rullzer THX |
|
Tested and works 👍 |
|
Odd, tested and works now 👍 |
|
@nickvergessen it did not work before? |
|
yes |
MorrisJobke
added a commit
that referenced
this pull request
Mar 30, 2015
Groupmanagers displayNamesInGroup should actually search in displaynames
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into #6967.
At first I thought it was a bug in the ajax/share.php however it seems the displayNamesInGroup only searchers uid's. I assume it should search in displayNames.
Lets see how Jenkins feels about this. Probably I can add a few more unit tests. But I'll look into that.
Once we have a clean fix in place this should probably be backported.