Favorite / filter by tag file lists do not have share status icon

[PVince81]

Steps

1. Create a folder "test"
2. Create a file "test/test.txt"
3. Mark a file "test/test.txt" as favorite
4. Tag that file with a tag "test1"
5. Share this file with link or with another user
6. Go to "Favorites" file list and check the share icon in the list row
7. Go to "Tags" file list, filter by "test1", check the share icon in the list row

Expected

Status shows that the file is shared

Actual

Status looks unshared

This is because now we use the OCS Share API's "get shares with subfiles from a given folder". However in these lists we're not technically in any folder, so we can't find the matching statuses.

It looks like the only way to solve this properly is to add new Webdav properties that contain sharing status information like recipients and share types.

@rullzer @DeepDiver1975

This is a regression from 8.2.2 but would be a bigger change, so setting it to 9.0.1 to investigate.
Normally I'd set it to 9.1 but as it's a regression, we'll need a proper solution soon...
However, since it only affects "Favorites" and "Tag filtered lists" it's not as bad as if it was "All files".

@cmonteroluque do you agree ? (setting to 9.0 until we discussed this)

[rullzer]

I really like this approach of exposing this information via webdav. So much more elegant than the calls to the OCS Share API. While the webdav call needs to happen anyway.

[rullzer]

But I agree also that 9.0.0 is way to risky

[PVince81]

Discussed with @cmonteroluque, moving to 9.0.1 for now. I hope we can find a quickfix until then.

[PVince81]

POC PR for new Webdav property: #22789

[PVince81]

@DeepDiver1975 you also mentioned the extra Webdav property back when we discussed this, so I guess you'll agree with the proposed solution ?

I'll carry on working on it to bring it to completion.

[PVince81]

Unfortunately this means "new APIs" in 9.0.1 due to the new Webdav property, if we consider such property an API...

[karlitschek]

hmm. not ideal. but a new property is a relatively small change